Skip to content

chore: add test fixes and additional debugging - #1270

Merged
jgwest merged 1 commit into
redhat-developer:masterfrom
jgwest:e2e-test-fixes-sept-2026
Sep 2, 2026
Merged

chore: add test fixes and additional debugging#1270
jgwest merged 1 commit into
redhat-developer:masterfrom
jgwest:e2e-test-fixes-sept-2026

Conversation

@jgwest

@jgwest jgwest commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:

  • Improves test logic for a few tests that were intermittently failing.
    • In HA redis case, use an eventually/consistently, rather than a single expect
    • Waiting for Route to be available before using in a couple cases
    • Waiting for Argo CD to be available before using
  • For some other tests that were failing, no logic changes, but I've added additional debug hooks for when they fail again.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

@jgwest
chore: add test fixes and additional debugging
73e96f9 
Signed-off-by: Jonathan West <jgwest@gmail.com>
@openshift-ci openshift-ci Bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chengfang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b0846755-1f6e-43fc-99b9-64b80deff856

📥 Commits

Reviewing files that changed from the base of the PR and between 2aeada6 and 73e96f9.

📒 Files selected for processing (10)
  • test/openshift/e2e/ginkgo/fixture/fixture.go
  • test/openshift/e2e/ginkgo/parallel/1-021_validate_rolebindings_test.go
  • test/openshift/e2e/ginkgo/parallel/1-025-validate-managed-by-change_test.go
  • test/openshift/e2e/ginkgo/parallel/1-029_validate_tls_secret_no_scale_test.go
  • test/openshift/e2e/ginkgo/parallel/1-030_validate_reencrypt_test.go
  • test/openshift/e2e/ginkgo/parallel/1-067_validate_redis_secure_comm_no_autotls_ha_test.go
  • test/openshift/e2e/ginkgo/parallel/1-132_validate_sensitive_annotation_masking_test.go
  • test/openshift/e2e/ginkgo/sequential/1-040_validate_quoted_RBAC_group_names_test.go
  • test/openshift/e2e/ginkgo/sequential/1-054_validate_argocd_agent_destination_mapping_test.go
  • test/openshift/e2e/ginkgo/sequential/1-064_validate_tcp_reset_error_test.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • argoproj-labs/argocd-operator (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Prevented diagnostic logging from crashing when namespace data is unavailable.
    • Improved cleanup handling so failed test runs consistently collect diagnostics and release temporary resources.

  • Tests

    • Increased wait times for slower application health and synchronization checks.
    • Added readiness checks for OpenShift routes before login and manifest retrieval.
    • Improved validation of Redis, Sentinel, and agent configuration with retry support and stability checks.
    • Expanded coverage for managed Argo CD destinations and RBAC-related scenarios.

Walkthrough

The E2E tests now protect debug output from typed-nil namespaces, centralize cleanup diagnostics, wait for Route and ArgoCD readiness, retry Redis and Sentinel validation, and use longer health-check timeouts.

Changes

E2E reliability

Layer / File(s) Summary
Typed-nil debug handling
test/openshift/e2e/ginkgo/fixture/fixture.go		 OutputDebug skips typed-nil namespace pointers before dereferencing them.
Parallel test teardown
test/openshift/e2e/ginkgo/parallel/1-021_validate_rolebindings_test.go, test/openshift/e2e/ginkgo/parallel/1-029_validate_tls_secret_no_scale_test.go, test/openshift/e2e/ginkgo/parallel/1-030_validate_reencrypt_test.go, test/openshift/e2e/ginkgo/parallel/1-132_validate_sensitive_annotation_masking_test.go		 Tests retain namespaces and cleanup callbacks for AfterEach diagnostics and cleanup.
Configuration polling and timing
test/openshift/e2e/ginkgo/parallel/1-067_validate_redis_secure_comm_no_autotls_ha_test.go, test/openshift/e2e/ginkgo/parallel/1-025-validate-managed-by-change_test.go		 Redis and Sentinel checks retry configuration reads and verify stable results. Application health checks use longer timeouts.
Route readiness gates
test/openshift/e2e/ginkgo/sequential/1-040_validate_quoted_RBAC_group_names_test.go, test/openshift/e2e/ginkgo/sequential/1-064_validate_tcp_reset_error_test.go		 Tests verify that the GitOps server Route exists and has an admitted ingress before continuing.
Argo CD agent readiness
test/openshift/e2e/ginkgo/sequential/1-054_validate_argocd_agent_destination_mapping_test.go		 Deployment helpers return both ArgoCD resources. The test waits for availability and allows more time for agent synchronization and health.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 73e96

The PR adjusts end-to-end test timing and failure diagnostics without changing product runtime behavior. No actionable merge-blocking risk remains, so it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 10 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the test fixes and added debugging changes.
Description check ✅ Passed The description clearly explains the intermittent test fixes, readiness waits, and debugging hooks.
  • Fix all pre-merge checks with AI

Warning

Repository analysis: Couldn't refresh redhat-developer/gitops-operator clone - clone failed: Stream initialization permanently failed: 14 UNAVAILABLE: Connection dropped

Comment @coderabbitai help to get the list of available commands.

@jgwest jgwest mentioned this pull request Sep 1, 2026
Merged
4 tasks
@jgwest

jgwest commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

AWS quota

/retest

@jgwest jgwest mentioned this pull request Sep 1, 2026
Merged
1 task
@jparsai

jparsai commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
Thanks

@openshift-ci openshift-ci Bot added the lgtm label Sep 2, 2026
@jgwest
jgwest merged commit fb60a7a into redhat-developer:master Sep 2, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdamSaleh AdamSaleh Awaiting requested review from AdamSaleh
@chetan-rns chetan-rns Awaiting requested review from chetan-rns
1 more reviewer
@jparsai jparsai jparsai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jparsai jparsai

Labels

kind/failing-test Categorizes issue or PR as related to a frequently failing test. lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgwest @jparsai